fix: mission related preconditions #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarwinAnim8or
approved these changes
Sep 10, 2024
aronwk-aaron
changed the title
aronwk-aaron
approved these changes
Sep 10, 2024
|
The logic was incorrect before, however if there are any tests you can do to make sure this change has the expected results, those would be appreciated. Noticed this 2 years ago and didnt fix because it wasnt broken lol. |
EmosewaMC
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic registered missions that had not been accepted as passing preconditions they should not. This PR seeks to use the GetMissionState function which takes care of this case.